Remove simtk references for openmm 7.6 #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umesh-timalsina
changed the title
Codecov Report
@@ Coverage Diff @@
## master #457 +/- ##
=======================================
Coverage 73.87% 73.87%
=======================================
Files 17 17
Lines 1849 1849
=======================================
Hits 1366 1366
Misses 483 483 |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jennyfothergill
approved these changes
Sep 3, 2021
|
I think this is good to merge after the tests pass. |
|
Assuming you intend to add the pin to the packaged builds, it would be useful to get a release with this in it soon. Thanks. |
daico007
approved these changes
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes all the simtk references for openmm imports and should be merged after ParmEd/ParmEd#1185 is resolved. Tests will fail for the timebeing.