Do not use deprecated OpenFF Toolkit iterator #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #541 +/- ##
=======================================
Coverage 69.21% 69.21%
=======================================
Files 16 16
Lines 1673 1673
=======================================
Hits 1158 1158
Misses 515 515 |
mattwthompson
force-pushed
the
toolkit-api
branch
from
584b730
to
80f6b6a
Compare
|
Failing test is due to the new pydantic release which impact gmso (mosdef-hub/gmso#742). I have made a new gmso built on its feedstock with pydantic pinned. Rerunning failed tests now and hopefully they will grab the correct build. |
|
Thanks @daico007! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary:
Topology.topology_atomswas deprecated in 0.11.0 and will be removed in the forthcoming 0.14.0 release.PR Checklist