Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in _get_untyped_sites #575

Merged
merged 3 commits into from
Jul 21, 2021

Conversation

daico007
Copy link
Member

This PR is a quick fix for a typo that @umesh-timalsina found in the _get_untyped_sties.

@daico007
Copy link
Member Author

Sorry for the messy commit history. I recycled the old branch that I used in the previous PR, and hence all these commits.

@codecov
Copy link

codecov bot commented Jul 19, 2021

Codecov Report

Merging #575 (8514ea9) into master (69e8d0d) will increase coverage by 0.83%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #575      +/-   ##
==========================================
+ Coverage   89.46%   90.29%   +0.83%     
==========================================
  Files          54       54              
  Lines        4205     4205              
==========================================
+ Hits         3762     3797      +35     
+ Misses        443      408      -35     
Impacted Files Coverage Δ
gmso/core/topology.py 96.22% <100.00%> (+8.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69e8d0d...8514ea9. Read the comment docs.

Copy link
Collaborator

@justinGilmer justinGilmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@justinGilmer justinGilmer merged commit 00f329c into mosdef-hub:master Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants