Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

turn off fail-fast & update readme #703

Merged
merged 5 commits into from
Dec 14, 2022

Conversation

daico007
Copy link
Member

@daico007 daico007 commented Dec 6, 2022

Right now, if what of the check failed, all the other unfinished checks will get canceled, which miss the point of testing on different OS. This PR turns that off. Similar to mosdef-hub/mbuild#1067

@daico007 daico007 marked this pull request as ready for review December 6, 2022 17:58
@daico007 daico007 changed the title turn off fail-fast turn off fail-fast & update readme Dec 6, 2022
@daico007
Copy link
Member Author

daico007 commented Dec 6, 2022

Will also try to update the readme to reflect recent changes

@codecov
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

Base: 91.48% // Head: 91.48% // No change to project coverage 👍

Coverage data is based on head (e4b5df6) compared to base (5085640).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #703   +/-   ##
=======================================
  Coverage   91.48%   91.48%           
=======================================
  Files          63       63           
  Lines        5450     5450           
=======================================
  Hits         4986     4986           
  Misses        464      464           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@daico007 daico007 merged commit 406336a into mosdef-hub:main Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant