-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cassandra gmso #756
Merged
Merged
Cassandra gmso #756
Changes from 1 commit
Commits
Show all changes
52 commits
Select commit
Hold shift + click to select a range
665feb6
Add fixed length bonds and angles to potential templates library.
rsdefever bd6ad75
Working to make MCF writer feature complete. Tests in progress.
rsdefever a6ce48d
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] a97826c
Add dimensions to Fixed Bond and Angle templates
emarinri c9bd1d1
Update keys in OPLS dihedral parameters dict
emarinri 014b7ae
Fix typed OPLS ethane test for MCF format
emarinri f41d5a9
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] f8e044c
Add typed ethane test.
emarinri 059ee03
Fix code style
emarinri 48fd600
Add fixture to parse mcf into sections
emarinri aed4c44
Support Pydantic v1 and v2 (#752)
mattwthompson 76415a8
Update MCF with GMSO builtin top site sorting
emarinri f093262
Use PotentialFilters to check for unique atomtypes
emarinri 44a0928
Add test to check charge neutrality
emarinri b9efc1b
Add test for incompatible expressions
emarinri f9f2759
Test full MCF for Mie-Xe and LJ-Ar
emarinri 5442297
Check charge neutrality in each molecule test
emarinri 86902e6
Add exception for not neutral system in MCF writer
emarinri 00cc2bc
Move parsing and neutrality check as utils
emarinri 73d24de
Merge branch 'main' into cassandra-gmso
daico007 6094aba
Merge branch 'main' into cassandra-gmso
daico007 51fdad8
minor docstring/comment fixes, swap out simplify with symengine expand
daico007 5f4ca3c
Merge branch 'main' of https://github.com/mosdef-hub/gmso into cassan…
daico007 1dc0a3e
[pre-commit.ci] pre-commit autoupdate (#763)
pre-commit-ci[bot] a1c3fb5
Test for 0.5 factor of OPLS dihedral potential
emarinri 4578812
Test to account for 0.5 factor in harmonic angles
emarinri 6668363
Test for rigid angles using the TIP3P model
emarinri 80c9be3
MCF writer test with topology with 10 argon mols
emarinri 2b0c7ee
Tentative output of multiple MCF from one Topology
emarinri 8317de4
Merge branch 'main' into cassandra-gmso
daico007 3951954
Change psi to phi and consts for ethylene xml test
emarinri 9579252
Test for 0.5 factor in OPLS dihedrals
emarinri ae69a8c
Add cassandra test for gmso
CalCraven 750d755
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] a7df9bc
Add test for two atom fragment
emarinri 685f8b8
Test for molecule with one ring
emarinri 1252d2b
Change nitrogen test to ethane ua
emarinri ec3a5dd
Add ethane rigid reference xml
emarinri a30d7bd
Use Fourier dihedrals as MCF standard dihedrals.
emarinri 64b5b8f
Fix dihedral type output fourier to opls
emarinri ad68575
Match MCF GMSO Angle header to mb Angle header
emarinri 0759365
Add a test comparing gmso and mbuild mcf writers
emarinri cf4e0c0
Use the Fourier converter for ethylene dihedrals
emarinri f462d5b
Write atom type masses instead of atom masses to account for UA beads
emarinri 2a40bbf
Output correct case for dihedral styles in MCFs
emarinri c12a120
Merge branch 'main' into cassandra-gmso
daico007 6ff41e2
Merge branch 'cassandra-gmso' of https://github.com/emarinri/gmso int…
emarinri c1b9c19
Run an energy calculation to compare GMSO and mBuild MCF writers
emarinri dcdc342
Merge branch 'main' into cassandra-gmso
daico007 3c12947
Update gmso/tests/test_mcf.py
daico007 a1f4853
Update gmso/tests/test_mcf.py
daico007 f38cfb6
Merge branch 'main' into cassandra-gmso
daico007 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this something we need to look into now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not think this is something we have to worry about for now.