Write charge in elementary charge unit (XML writer) #794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…charge_in_elementary
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #794 +/- ##
==========================================
- Coverage 92.37% 92.35% -0.03%
==========================================
Files 66 66
Lines 6861 6864 +3
==========================================
+ Hits 6338 6339 +1
- Misses 523 525 +2 ☔ View full report in Codecov by Sentry. |
CalCraven
approved these changes
Jan 15, 2024
Co-authored-by: CalCraven <54594941+CalCraven@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the XML writer will write out coulomb charge by default. This is partially due to the missing
u.Unit("elementary_charge")in the unit default registry (see #792 for related issue). This PR will change the default to write out inelementary_charge, by using the custom registryGMSOUnitRegistryto store the charge unit and write them out to ff xml.