Fix for bug with mbuild missing edges in bond graph #1049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
|
Fixes Issue #1048 |
Codecov Report
@@ Coverage Diff @@
## main #1049 +/- ##
=======================================
Coverage 90.39% 90.39%
=======================================
Files 64 64
Lines 9027 9027
=======================================
Hits 8160 8160
Misses 867 867
Continue to review full report at Codecov.
|
daico007
approved these changes
Aug 3, 2022
| @@ -147,7 +147,7 @@ def compose(self, graph): | |||
| adj = self._adj | |||
| for node, neighbors in graph._adj.items(): | |||
| if self.has_node(node): | |||
| (adj[node].add(neighbor) for neighbor in neighbors) | |||
| [adj[node].add(neighbor) for neighbor in neighbors] | |||
There was a problem hiding this comment.
It's interesting how this could make such a big different.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary:
PR Checklist