Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Produce n=2 when ports are not capped #1069

Merged
merged 1 commit into from
Dec 12, 2022

Conversation

jaclark5
Copy link
Contributor

PR Summary:

Resolves #1068

PR Checklist


  • [NA] Includes appropriate unit test(s)
  • [NA] Appropriate docstring(s) are added/updated
  • Code is (approximately) PEP8 compliant
  • Issue(s) raised/addressed?

Copy link
Member

@daico007 daico007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the PR!

@codecov
Copy link

codecov bot commented Dec 12, 2022

Codecov Report

Base: 90.51% // Head: 90.49% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (419f988) compared to base (82977a2).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1069      +/-   ##
==========================================
- Coverage   90.51%   90.49%   -0.02%     
==========================================
  Files          61       61              
  Lines        6156     6157       +1     
==========================================
  Hits         5572     5572              
- Misses        584      585       +1     
Impacted Files Coverage Δ
mbuild/lib/recipes/alkane.py 38.88% <0.00%> (-0.74%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@daico007 daico007 merged commit 8e48eb4 into mosdef-hub:main Dec 12, 2022
thangckt added a commit to thangckt/mbuild that referenced this pull request Dec 13, 2022
Produce n=2 when ports are not capped (mosdef-hub#1069)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When Alkane(n=2, cap_front=False, cap_end=False) the output is n=1
2 participants