Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update hoomdxml.py #798

Merged
merged 1 commit into from
Oct 14, 2020
Merged

Update hoomdxml.py #798

merged 1 commit into from
Oct 14, 2020

Conversation

mikemhenry
Copy link
Member

@mikemhenry mikemhenry commented Oct 12, 2020 •
edited
Loading

PR Summary:

When writing the xml header with the units for scaling, we are off by the conversion factor used by parmed.

PR Checklist

  • Includes appropriate unit test(s)
  • Appropriate docstring(s) are added/updated
  • Code is (approximately) PEP8 compliant
  • Issue(s) raised/addressed?

@codecov
Copy link

codecov bot commented Oct 12, 2020 •
edited
Loading

Codecov Report

Merging #798 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #798   +/-   ##
=======================================
  Coverage   82.86%   82.86%           
=======================================
  Files          58       58           
  Lines        4932     4932           
=======================================
  Hits         4087     4087           
  Misses        845      845
Impacted Files Coverage Δ
mbuild/formats/hoomdxml.py 98.65% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f47077e...0e7fa8a. Read the comment docs.

chrisjonesBSU
chrisjonesBSU approved these changes Oct 12, 2020
View reviewed changes
Copy link
Contributor

@chrisjonesBSU chrisjonesBSU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chrisjonesBSU chrisjonesBSU mentioned this pull request Oct 12, 2020
Closed
justinGilmer
justinGilmer approved these changes Oct 14, 2020
View reviewed changes
Copy link
Contributor

@justinGilmer justinGilmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daico007 daico007 merged commit aefb71f into master Oct 14, 2020
@daico007 daico007 deleted the mikemhenry-patch-2 branch May 25, 2021 17:16
umesh-timalsina referenced this pull request in GOMC-WSU/MoSDeF-GOMC Mar 22, 2022
Update hoomdxml.py (#798)
e46b598
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinGilmer justinGilmer justinGilmer approved these changes

@chrisjonesBSU chrisjonesBSU chrisjonesBSU approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mikemhenry @justinGilmer @chrisjonesBSU @daico007