Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assorted cleanup and installation standardization #22

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mattwthompson
Copy link
Member

I changed a few of the notebooks to have a requirements.txt file that attempts to specify the packages needed to run it. With this changes, each notebook starts out with a conda install --file requirements.txt line. At best, it adds a couple seconds to a notebook. At worst, it should standardize what is need to run each notebook. Tagging #2

For the two notebooks that use GROMACS, I added a bash line that tries to find a gmx execuatable and, if that fails, installs it from conda. No need to have a duplicate install floating around, but it's better to grab from conda than not have at all or require a user build it themselves.

If these changes are popular, I can go through the other notebooks and unify them. I only did the GROMACS ones because I didn't want to install HOOMD-blue or GOMC on this machine.

I also included a couple other fixes so that things would actually run.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant