Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 file store and fetch #3

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

S3 file store and fetch #3

wants to merge 2 commits into from

Conversation

bacosmin
Copy link

@bacosmin bacosmin commented Feb 2, 2016

on each save if the keys are set the app will store also on s3
This is useful for Heroku since it is has readonly file system .

Cosmin Barbu and others added 2 commits February 2, 2016 15:48
@mose
Copy link
Owner

mose commented Feb 2, 2016

Neat addition :)

It may require some extra work, for a more modular approach of the storage method and have an appropriate test coverage.

I also wonder how the I18n backend facility evolved recently, because this kind of modulratity could have been delegated to that class, I think. Gotta check that as.

Anyways, I will check and test this change soon and merge if it doesn't break things. We can add some refactoring later down the road for modularity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants