Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error with jekyll 2.0.2 #22

Closed
jbleuzen opened this issue May 7, 2014 · 9 comments
Closed

Error with jekyll 2.0.2 #22

jbleuzen opened this issue May 7, 2014 · 9 comments
Labels
bug Jekyll 2

Comments

@jbleuzen
Copy link

jbleuzen commented May 7, 2014

Wanted to upgrade to latest jekyll just for fun, encountered a bug and it seams that deep_merge is the culprit on line 106.

Here is the following error I got :

...
  Liquid Exception: undefined method `deep_merge' for #<Hash:0x007fd05a730488> in _includes/head.html, included in _layouts/post.html
/Users/johan/.rbenv/versions/2.0.0-p247/lib/ruby/gems/2.0.0/gems/jekyll-2.0.2/lib/jekyll/tags/include.rb:114:in `rescue in render': undefined method `deep_merge' for #<Hash:0x007fd05a730488> (Jekyll::Tags::IncludeTagError)
        from /Users/johan/.rbenv/versions/2.0.0-p247/lib/ruby/gems/2.0.0/gems/jekyll-2
....

Don't bother to solve that quickly, I reverted to a previous version of jekyll :)
@daneden
Copy link

daneden commented May 8, 2014

+1 on this error.

@moshen moshen added the bug label May 12, 2014
@moshen
Copy link
Owner

moshen commented May 12, 2014

Thanks guys, Jekyll 2 compatibility is the first thing on my list when I get a moment.

@ryanhornberger
Copy link

+1 great work so far

@johnykov
Copy link

awesome, I've already impaled myself on this while calling "jekyll build/serve"

jekyll 2.0.3 | Error: undefined method `deep_merge' for #Hash:0x007fa8f98723b0

@johnykov johnykov mentioned this issue May 22, 2014
Closed
@moshen moshen closed this as completed in 3a462d9 May 22, 2014
moshen added a commit that referenced this issue May 22, 2014
@moshen
Fixes #22 deep_merge => Utils.deep_merge_hashes
d8c2211 
Fixes Jekyll 2.0 compatibility

What I've learned today: Other people's monkey patches will change on
you.
@moshen
Copy link
Owner

moshen commented May 22, 2014

master is fixed, tested with Jekyll 2.0.3.

@jbleuzen
Copy link
Author

Perfect, thank you !

@iamsalnikov
Copy link

Jekyll 2.1.1
Ruby 2.1.2

Same error (jekyll 2.1.1 | Error: undefined method 'deep_merge')

@moshen
Copy link
Owner

moshen commented Jul 20, 2014

Have you tried the current master? Not using the deep_merge util anymore.

@iamsalnikov
Copy link

@moshen, I did not use current master. But when I downgrade my ruby to 2.0 all works fine.

@srawlins srawlins mentioned this issue Aug 28, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Jekyll 2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@moshen @jbleuzen @daneden @johnykov @iamsalnikov @ryanhornberger