Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added pagetoken args to Places, Updated URI #48

Closed
wants to merge 1 commit into from

Conversation

Akiren
Copy link

@Akiren Akiren commented Jul 9, 2014

exports.places has been updated with pagetoken args which is necessary
to get subsequent places as the initial request returns 20, pagetoken
must be passed to get additional places from a location.

Also updated the URI to the new Google places URI as documented here
https://developers.google.com/places/documentation/search, the lat/lon
arguments were also failing on the stringily command which was
converting the +, into ascii hex codes and passed to the created URI

exports.places has been updated with pagetoken args which is necessary
to get subsequent places as the initial request returns 20, pagetoken
must be passed to get additional places from a location.

Also updated the URI to the new Google places URI as documented here
https://developers.google.com/places/documentation/search, the lat/lon
arguments were also failing on the stringily command which was
converting the +, into ascii hex codes and passed to the created URI
@Akiren Akiren changed the title Update Google Place API Added Pagetoken args to Places, Updated URI Jul 9, 2014
@Akiren Akiren changed the title Added Pagetoken args to Places, Updated URI Added pagetoken args to Places, Updated URI Jul 9, 2014
@fabriziomoscon
Copy link
Collaborator

@Akiren I preferred to merge first this: #26 since it doesn't break backwards compatibility since the pagetoken parameter is passed at the end.

Could you please:

  • integrate the new changes in your fork
  • open another pull request with the URL change
  • close this one

@fabriziomoscon
Copy link
Collaborator

please see #70

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants