Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comparing with remote workspace folder fails #81

Closed
mforkel opened this issue May 26, 2021 · 7 comments
Closed

Comparing with remote workspace folder fails #81

mforkel opened this issue May 26, 2021 · 7 comments
Labels
bug Something isn't working help wanted Extra attention is needed Stale

Comments

@mforkel
Copy link

mforkel commented May 26, 2021

I tried to use Compare Folders in a workspace that contains local folders and remote folders accessed with the SSH FS extension. An attempt to compare a local folder to a remote folder results in an error message "Oops, something went wrong while comparing" and this output:

error while comparing
{
  "errno": -2,
  "code": "ENOENT",
  "syscall": "lstat",
  "path": "/scripts"
}

Comparing a local folder to the remote root folder gives this output:

error while comparing
{
  "errno": -13,
  "syscall": "lstat",
  "code": "EACCES",
  "path": "//mnt/c/DumpStack.log.tmp"
}

The file DumpStack.log.tmp is not accessible. In both cases, Compare Folders incorrectly report that there are no differences in any file at the same path.

Comparing a file in a local folder to a file in a remote folder works fine.

The SSH FS documentation for remote workspace folders claims that SSH FS works with extensions using the vscode.workspace.fs API. May be Compare Folders is no using that API?

@moshfeu
Copy link
Owner

moshfeu commented May 27, 2021

Thanks for the report.
I'll look into it as soon as I can.

@moshfeu moshfeu added bug Something isn't working help wanted Extra attention is needed labels May 27, 2021
@stale
Copy link

stale bot commented Jul 26, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Jul 26, 2021
@stale stale bot closed this as completed Aug 2, 2021
@moshfeu moshfeu reopened this Jul 14, 2022
@stale stale bot removed the wontfix This will not be worked on label Jul 14, 2022
@qiyan98
Copy link

qiyan98 commented Jul 18, 2023

Same here. I was trying to compare two folders on the remote server and it took forever to load. The same folders on my local laptop work smoothly.

@moshfeu
Copy link
Owner

moshfeu commented Aug 4, 2023

Hi @qiyan98 and @mforkel .
Sorry for the very late reply. I'm not using remote folders so I lack knowledge in that area.
I'm not sure it's related but the extension uses an external library for comparison. I'm sure that the library doesn't use vscode.workspace.fs API because it's a normal node library.
Maybe I can ask the librarys owner to allow consumers to pass the fsmodule so in our case it would usevscode.workspace.fs.

Do you know an easy way to connect to ssh so I could test it myself?

@mforkel
Copy link
Author

mforkel commented Aug 17, 2023

Thanks for looking into this, moshfeu

Do you know an easy way to connect to ssh so I could test it myself?

I'm not sure I understand your question. I guess a basic setup for testing would be a remote machine with an SSH server installed and your Windows machine with VS Code and the Remote SSH extension (see Remote Development using SSH). Then you could use your extension to compare folders on the remote and the local machine.

Copy link

github-actions bot commented Jan 7, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added Stale and removed Stale labels Jan 7, 2024
Copy link

github-actions bot commented Mar 9, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale label Mar 9, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed Stale
Projects
None yet
Development

No branches or pull requests

3 participants