Dismiss difference fix

[sampellino]

Fix for issue #145

---

Before:

before.mp4

After:

after.mp4

[moshfeu]

Thanks for the quick fix! Please let me a few days to get into it. If you have any idea how to avoid specific platform handling, that would be great. Cross platform code is usually feels better than platform-specific

[sampellino]

Thanks for the quick fix! Please let me a few days to get into it. If you have any idea how to avoid specific platform handling, that would be great. Cross platform code is usually feels better than platform-specific

I've never tried writing a VSCode extension, but I can take a crack at trying to make the code platform agnostic👌

[moshfeu]

Hi @sampellino :)
The root cause is that the dir-compare package returns different paths in windows (with the scheme) and mac (without the scheme) and I guess that it's because of the different file system

What do you think about changing the filterIgnoredFromDiffs so it would compare only paths (force to remove the schema which is irrelevant here anyway)?

vscode-compare-folders/src/providers/foldersCompareProvider.ts

Lines 185 to 195 in c70ebb8

	private filterIgnoredFromDiffs() {
	this._diffs!.distinct = this._diffs!.distinct
	.filter(diff => {
	const { path: path1 } = Uri.parse(diff[0]);
	const { path: path2 } = Uri.parse(diff[1]);
	console.log(path1, path2);
	return !this.ignoreDifferencesList.has(path1) &&
	!this.ignoreDifferencesList.has(path2);
	});
	}

Here is in a commit

[moshfeu]

I'll merge now and will pull my suggestion afterwards
🙏

[sampellino]

I'll merge now and will pull my suggestion afterwards 🙏

Hey, sorry I didn't get back to you earlier! I can still try to look into the platform-agnostic solution this week if I get a chance. My job has been taking a lot of my time these past few weeks.

Glad to see it went to prod! Let me know if you need help with any future issues, I'd be more than happy to contribute.

[moshfeu]

No worries, unfortunately we need to work from time to time 🙃

I've pushed the agnostic platform solution, I'd be happy for you to review it

Thanks for willing to contribute, really appreciated!
Any idea for features or ux improvements would be great

[sampellino]

Confirmed working for Win 11 ✅

Recording.2024-04-02.194840.mp4