-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: respect .gitignore #97
Conversation
Glad that you like the idea. Some points:
|
Thank you for the valuable feedback! I'll take care of the points you mentioned. |
2dc5ce7
to
46448d9
Compare
still not working
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Bottom line, this PR adds the core feature and handles patterns start with |
Almost a year later 😅 I finalized the feature but ".gitignore files from sub-folders should also be read" which, as I mentioned, more complicated.. not rocket science, but still. @placasse would you mind to give it a try? |
Sure!
then file a1.txt should not be ignored. |
Thanks for the quick feedback! @atplacasse If this is the only issue, I'll merge the PR and kindly ask you to create a new issue so people could enjoy the feature until we figure it out. |
Sure. I will take a look in the next few days. |
Thanks 🙏 |
close #96