Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-contig gff parsing: Range issue #33

Closed
acarafat opened this issue Aug 22, 2023 Discussed in #32 · 5 comments
Closed

Multi-contig gff parsing: Range issue #33

acarafat opened this issue Aug 22, 2023 Discussed in #32 · 5 comments
Labels
bug Something isn't working

Comments

@acarafat
Copy link

Discussed in #32

Originally posted by acarafat August 22, 2023
I am working with a GFF file that contains multiple contigs, but the ##sequence-region only shows for the contig 1 in the gff header info.

Currently, while using .get_seqid2size() from gff parser, present code relies on ##sequence-region tag, therefore it gets the range for rest of the contigs wrong.

It could be solved by not relying on the ##sequence-region, since many gff file generated by different programs may not contain this comment.

@moshi4
Copy link
Owner

moshi4 commented Aug 23, 2023

Hi @acarafat,

Thank you for reporting this issue.

Looking back at the code of the Gff parser, as you said, if there is no ##sequence-region tag, it was not getting the contig range correctly.

There was a bug in the code that assumed the absence of the ##sequence-region tag.
Since it does not work as expected, I will release a fixed version as v0.5.1 soon. Please wait a moment.

moshi4 added a commit that referenced this issue Aug 23, 2023
Fix a bug that the correct size could not be obtained when `##sequence-region` tag does not exist and multiple contigs are included
@moshi4
Copy link
Owner

moshi4 commented Aug 23, 2023

I've released v0.5.1, so give it a try and see if it works for you.

@acarafat
Copy link
Author

I've released v0.5.1, so give it a try and see if it works for you.

Thank you so much!

@moshi4 moshi4 closed this as completed Aug 25, 2023
@acarafat
Copy link
Author

acarafat commented Sep 6, 2023

Hello, I'm just realized that the .gbk parser also has the same issue.

Best,
Arafat

@moshi4
Copy link
Owner

moshi4 commented Sep 7, 2023

There is no ##sequence-region tag in the Genbank file.
Without additional explanation, I am not sure what same issue means.

@moshi4 moshi4 added the bug Something isn't working label May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants