Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle database or diskfull error #625

Open
ravikp opened this issue Mar 8, 2023 · 9 comments
Open

Handle database or diskfull error #625

ravikp opened this issue Mar 8, 2023 · 9 comments
Assignees
Labels
BLE BLE Transefer of VCs enhancement New feature or request HotFix Hotfix release Major
Milestone

Comments

@ravikp
Copy link
Contributor

ravikp commented Mar 8, 2023

Is your feature request related to a problem? Please describe.
When the database(from AsyncStorage lib), gets full, the UI to store the VC's gets hung.

Describe the solution you'd like
Instead of show the UI getting frozen, an error needed to be shown for the user to recover from the error

Describe alternatives you've considered

  • Delete oldest VC's behind the scenes

Additional context
Add any other context or screenshots about the feature request here.

@ravikp ravikp added enhancement New feature or request triage This issue is pending confirmation and planning and should not be worked on yet labels Mar 8, 2023
@ravikp ravikp added the Major label Mar 8, 2023
@ravikp
Copy link
Contributor Author

ravikp commented Mar 8, 2023

@nayakrounak - Need input clarification on what happens to the incoming VC when we see that there is no space to save the VC?

@lsivanand
Copy link

If we are going to delete oldest VC's automatically, (behind the scenes), we should have some where mentioned in the documentation that when or after how many VCs the older will deleted..

Also it is not the number of VCs.. it depends on each VC size.. (depending the data (text/image) in the VC..

@ravikp
Copy link
Contributor Author

ravikp commented Mar 8, 2023

It is required to understand the limits of the system, what are those limits, and how to address when the system reaches its limits.

@ravikp
Copy link
Contributor Author

ravikp commented Mar 8, 2023

That is the reason for keeping the ticket in input clarification phase.

tilak-puli added a commit to tw-mosip/inji-wallet that referenced this issue Mar 8, 2023
@ravikp ravikp assigned nayakrounak and unassigned krishnakumar4a4 Mar 8, 2023
@ravikp ravikp added the BLE BLE Transefer of VCs label Mar 8, 2023
tilak-puli added a commit to tw-mosip/inji-wallet that referenced this issue Mar 8, 2023
@nayakrounak
Copy link

For now, let show an error message, stating that, no more cards can be added or received as app data is full (Please reframe the statement as needed).

We will later give a patch with feature to remove VC (received or downloaded) and update the error message.

Sasi also has some comments over this, we should store the received VIDs externally and add a reference in app data. We can discuss this after our release and add this feature later.

tilak-puli added a commit to tw-mosip/inji-wallet that referenced this issue Mar 10, 2023
…reen and Purple theme button being large in multiple places
tilak-puli added a commit to tw-mosip/inji-wallet that referenced this issue Mar 14, 2023
tilak-puli added a commit to tw-mosip/inji-wallet that referenced this issue Mar 14, 2023
tilak-puli added a commit to tw-mosip/inji-wallet that referenced this issue Mar 14, 2023
tilak-puli added a commit to tw-mosip/inji-wallet that referenced this issue Mar 14, 2023
tilak-puli added a commit to tw-mosip/inji-wallet that referenced this issue Mar 14, 2023
@krishnakumar4a4 krishnakumar4a4 added this to the 15th MAR 23 milestone Mar 14, 2023
adityankannan-tw pushed a commit to tw-mosip/inji-wallet that referenced this issue Mar 14, 2023
ravikp added a commit to tw-mosip/inji-wallet that referenced this issue Mar 14, 2023
fea(mosip#625): Show dialog when VC can't be stored on the sqlite disk full error
tilak-puli added a commit to tw-mosip/inji-wallet that referenced this issue Mar 16, 2023
@vharsh
Copy link
Member

vharsh commented Mar 17, 2023

The following change is available on branch=0.9 & on branch=develop as part of the 17th March, 2023 release and a custom error will be shown as requested.

PR for mosip/inji(branch=develop): #655,
commit: aff1c4f
PR for mosip/inji(branch=0.9): #653
commit: 4c2ca4b

@ravikp ravikp removed the triage This issue is pending confirmation and planning and should not be worked on yet label Mar 20, 2023
@gsasikumar
Copy link
Member

While this is an important problem we need to solve it more better. I would prefer not to store the VC directly in the DB rather in a encrypted file. and the reference and metadata in the DB.

Can we make this as an enhancement?

Also i wanted to cache the schema that the VC refers. This will be needed for our offline validation of VC.

@Raginikrishnamurthy
Copy link
Contributor

This bug is not a part of the 0.9 release, hence assigning back to dev team for further investigation and changes as mentioned by Sasikumar.

@Sujithbn Sujithbn assigned krishnakumar4a4 and unassigned vharsh Apr 3, 2023
@Sujithbn Sujithbn added the HotFix Hotfix release label Apr 3, 2023
@Pragya279
Copy link

This bug has been moved to Jira.
Link to Jira bug: https://mosip.atlassian.net/browse/MOSIP-26846

@santhoshsunder santhoshsunder added bug Something isn't working and removed bug Something isn't working labels Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLE BLE Transefer of VCs enhancement New feature or request HotFix Hotfix release Major
Projects
Status: QA (test)
Development

No branches or pull requests