[Release 17-03-2023] iOS code refactor & UI improvements #653

vharsh · 2023-03-17T10:13:37Z

Enhancements

[Android | iOS] Remove accept/ discard buttons on verifier (Remove Accept/Discard Buttons on Verifier #617)
[Android | iOS] Display error pop up on DB write errors (Handle database or diskfull error #625)
[Android | iOS] Retry failure frame is 5 times at max (Increase and set failure frame limit for VC transfer #627)

Fixes

[Android | iOS] Green border for selected VC in purple theme (Green border missing on purple theme #635)
[iOS] Request camera permission after bluetooth permission in iOS (Camera permission not requested in iPhone #502)
[iOS] Display bluetooth error message based on state iOS (iOS doesn’t turn on bluetooth if disabled when Scanner is opened #580)
[Android] The buttons not aligned in purple theme (Android - Button are not aligned properly in purple APK #631)

…oth is off

…guages

…lly save

…loading popup while saving

…ing large in multiple places

…n-screen fix(mosip#631): Verify Button going behind the screen and Purple theme button being large in multiple places

…languages

…h permission in iOS

…on text

…a full error

…essage

…in the sharing card screen

…otp verification screen in purple color

fix(mosip#502): Camera permission not requested on iPhone

…oth is off

…all languages

…e themes

feat(mosip#617): hide Save/Discard buttons on Verifier and implement auto save of VC

feat(mosip#580): Handle error messages for Bluetooth On and Off state

fea(mosip#625): Show dialog when VC can't be stored on the sqlite disk full error

ravikp · 2023-03-17T10:47:21Z

Looks good to me.

ravikp

Looks good to me.

Pooja Babusing and others added 30 commits March 5, 2023 23:45

feat(mosip#580): [Pooja] Display error message in english when blueto…

593a427

…oth is off

feat(mosip#580): [Pooja] added error labels in all languages

55bb944

feat(mosip#580): [Pooja] disable camera when bluetooth is off

bf771c2

feat(mosip#580): [Pooja] refactored to disable the camera when blueto…

843c86a

…oth is off

feat(mosip#580): [Pooja] refactored bluetooth state labels in all lan…

2c55f33

…guages

feat(mosip#617): hide Save/Discard buttons on Verifier and automatica…

05df0a0

…lly save

feat(mosip#625):[Tilak|Adityan] show error popup if saving fails and …

79e6627

…loading popup while saving

feat(mosip#625):[Tilak|Adityan] show saving overlay only after 1sec

45e4cc1

feat(mosip#580): [Pooja] refactored to display single error at once

3c3fd6f

feat(mosip#580): [Pooja] Added margin to the error labels

c7ecafd

fix: Verify Button going behind the screen and Purple theme button be…

191fade

…ing large in multiple places

Merge pull request mosip#632 from ravikp/fix-verify-button-in-qr-logi…

420c7f3

…n-screen fix(mosip#631): Verify Button going behind the screen and Purple theme button being large in multiple places

feat(mosip#617): [Tilak|Adityan] change labels for new button in all …

7248718

…languages

feat(mosip#502): [Pooja] Request for camera permission after bluetoot…

385bde6

…h permission in iOS

feat(mosip#502): [Pooja] add margin to missing camera permission text

7d6f83d

feat(mosip#502): [Pooja] added translation of missing camera permissi…

85f5f04

…on text

feat(mosip#625):[Tilak/Adityan] Add a new overlay message for sql dat…

7544c33

…a full error

feat(mosip#625):[Tilak/Adityan] Add translations for sql full error m…

1a0138b

…essage

feat(mosip#625):[Tilak/Adityan] Add typing for request machine

61470f5

refactor(mosip#635): [Bhargavi] add green border for the selected vc …

113da74

…in the sharing card screen

refactor(mosip#611): [Bhargavi] show input cursor and mobile logo of …

545720f

…otp verification screen in purple color

feat(mosip#502): rephrase comment

271d2a1

Merge pull request #18 from ravikp/camera-permission-iOS

2a73fc7

fix(mosip#502): Camera permission not requested on iPhone

feat(mosip#580): [Pooja] display error message in android when blueto…

7d6a297

…oth is off

feat(mosip#580): [Pooja] add bluetooth error message translations in …

c2d7125

…all languages

feat(mosip#625):[Tilak/Adityan] Refactor names in store error flow

4194b4f

feat(mosip#625):[Tilak/Adityan] Refactor names in store error flow

28c5d86

refactor(mosip#611): [Bhargavi|Vijay] show cursor colors in respectiv…

f270f61

…e themes

Merge pull request #13 from ravikp/remove-save/discard-buttons

573ce4b

feat(mosip#617): hide Save/Discard buttons on Verifier and implement auto save of VC

Merge branch 'develop' into new-error-overlay-for-sql-full-error

5121dc3

Pooja Babusing and others added 7 commits March 14, 2023 17:28

feat(mosip#580): [Pooja] refactor to display error messages

5b113e7

Merge pull request #10 from ravikp/bluetooth-state-text

767a3c1

feat(mosip#580): Handle error messages for Bluetooth On and Off state

refactor(mosip#625): [Adityan] refactor error message name

3e5ac1e

Merge pull request #19 from ravikp/new-error-overlay-for-sql-full-error

1de1738

fea(mosip#625): Show dialog when VC can't be stored on the sqlite disk full error

feat(mosip#580): [Pooja] fix camera not loading for second time transfer

1b070ab

Merge remote-tracking branch 'upstream/develop' into develop-15-03-2023

62f8b0b

chore: bump up the tuvali version to v0.3.8 for release 17-03-2023

740a4c5

vharsh marked this pull request as ready for review March 17, 2023 10:40

krishnakumar4a4 requested a review from ravikp March 17, 2023 10:48

ravikp approved these changes Mar 17, 2023

View reviewed changes

ravikp merged commit 4c2ca4b into mosip:0.9 Mar 17, 2023

swatigoel deleted the develop-15-03-2023 branch June 4, 2024 11:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Release 17-03-2023] iOS code refactor & UI improvements #653

[Release 17-03-2023] iOS code refactor & UI improvements #653

vharsh commented Mar 17, 2023 •

edited

Loading

ravikp commented Mar 17, 2023

ravikp left a comment

[Release 17-03-2023] iOS code refactor & UI improvements #653

[Release 17-03-2023] iOS code refactor & UI improvements #653

Conversation

vharsh commented Mar 17, 2023 • edited Loading

Enhancements

Fixes

ravikp commented Mar 17, 2023

ravikp left a comment

Choose a reason for hiding this comment

vharsh commented Mar 17, 2023 •

edited

Loading