Skip to content

Commit

Permalink
Goroutine profile known risk improvement (#111)
Browse files Browse the repository at this point in the history
Add explanation for goroutine dump risks
  • Loading branch information
Jun10ng committed Jul 19, 2022
1 parent 05aa358 commit a1146af
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,8 @@ h, _ := holmes.New(

## known risks

Collect a goroutine itself [may cause latency spike](https://github.com/golang/go/issues/33250) because of the STW.
If golang version < 1.19, collect a goroutine itself [may cause latency spike](https://github.com/golang/go/issues/33250) because of the long time STW.
At golang 1.19, it has been optz by concurrent way at this [CL](https://go-review.googlesource.com/c/go/+/387415/).

## Show cases
[Click here](./doc/example.md)
Expand Down

0 comments on commit a1146af

Please sign in to comment.