Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(report): pass scene information to reporter #119

Merged
merged 3 commits into from Sep 9, 2022
Merged

feat(report): pass scene information to reporter #119

merged 3 commits into from Sep 9, 2022

Conversation

dumbFeng
Copy link
Contributor

@mosn-community-bot
Copy link

Hi @dumbFeng, welcome to mosn community, Please sign Contributor License Agreement!

After you signed CLA, we will automatically sync the status of this pull request in 3 minutes.

@Jun10ng
Copy link
Contributor

Jun10ng commented Aug 30, 2022

https://github.com/mosn/holmes#reporter-dump-event
这里还需要补充下文档，thanks

Jun10ng
Jun10ng reviewed Sep 6, 2022
View reviewed changes
reporters/reporter_test.go Outdated Show resolved Hide resolved
@Jun10ng
Copy link
Contributor

Jun10ng commented Sep 7, 2022

LGTM.

doujiang24
doujiang24 reviewed Sep 8, 2022
View reviewed changes
Copy link
Member

@doujiang24 doujiang24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建议你先在自己项目里把这个特性用起来的，也就是测试一下的，看看有没有其他的意外
其他没啥问题了

report.go Show resolved Hide resolved
@doujiang24 doujiang24 merged commit 9588228 into mosn:master Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doujiang24 doujiang24 doujiang24 left review comments

@Jun10ng Jun10ng Jun10ng approved these changes

Assignees
No one assigned
Labels
cla:yes First-time contributor size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dumbFeng @Jun10ng @doujiang24