Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add etcd lock #128

Merged
merged 12 commits into from
Jul 12, 2021
Merged

Add etcd lock #128

merged 12 commits into from
Jul 12, 2021

Conversation

stulzq
Copy link
Member

@stulzq stulzq commented Jul 8, 2021

What this PR does:

Add etcd lock

Which issue(s) this PR fixes:

Fixes #127

@mosn-community-bot
Copy link

Hi @stulzq, welcome to mosn community, Please sign Contributor License Agreement!

After you signed CLA, we will automatically sync the status of this pull request in 3 minutes.

@seeflood
Copy link
Member

seeflood commented Jul 8, 2021

写的很棒!!感谢贡献

@codecov-commenter
Copy link

Codecov Report

Merging #128 (1906c1d) into main (caf6a62) will increase coverage by 0.14%.
The diff coverage is n/a.

❗ Current head 1906c1d differs from pull request most recent head 0fcd80c. Consider uploading reports for the commit 0fcd80c to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #128      +/-   ##
==========================================
+ Coverage   44.63%   44.77%   +0.14%     
==========================================
  Files          41       41              
  Lines        1425     1425              
==========================================
+ Hits          636      638       +2     
+ Misses        741      740       -1     
+ Partials       48       47       -1     
Impacted Files Coverage Δ
...kg/filter/network/tcpcopy/persistence/work_pool.go 90.00% <0.00%> (+5.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update caf6a62...0fcd80c. Read the comment docs.

components/lock/etcd/etcd_lock.go Outdated Show resolved Hide resolved
components/lock/etcd/etcd_lock.go Outdated Show resolved Hide resolved
@seeflood
Copy link
Member

seeflood commented Jul 9, 2021

刚发现昨晚的cr忘提交了……

@stulzq stulzq requested a review from seeflood July 9, 2021 02:22
Copy link
Member

@seeflood seeflood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seeflood seeflood merged commit aa9bc97 into mosn:main Jul 12, 2021
@seeflood
Copy link
Member

Thanks again for your contribution,and welcome to the MOSN&Layotto community!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Etcd to implement Distributed Lock API
3 participants