Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add Dapr pubsub API #406

Closed
wants to merge 14 commits into from
8 changes: 2 additions & 6 deletions pkg/grpc/dapr/dapr_api.go
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,8 @@ type daprGrpcAPI struct {
sendToOutputBindingFn func(name string, req *bindings.InvokeRequest) (*bindings.InvokeResponse, error)
secretStores map[string]secretstores.SecretStore
// app callback
AppCallbackConn *grpc.ClientConn
AppCallbackConn *grpc.ClientConn
topicPerComponent map[string]TopicSubscriptions
// json
json jsoniter.API
}
Expand All @@ -77,11 +78,6 @@ func (d *daprGrpcAPI) Init(conn *grpc.ClientConn) error {
return d.startSubscribing()
}

func (d *daprGrpcAPI) startSubscribing() error {
// TODO
return nil
}

func (d *daprGrpcAPI) Register(s *grpc.Server, registeredServer mgrpc.RegisteredServer) (mgrpc.RegisteredServer, error) {
dapr_v1pb.RegisterDaprServer(s, d)
return registeredServer, nil
Expand Down
300 changes: 300 additions & 0 deletions pkg/grpc/dapr/dapr_api_pubsub.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,300 @@
/*
* Copyright 2021 Layotto Authors
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package dapr

import (
"context"
"encoding/base64"
"errors"
"fmt"
"github.com/dapr/components-contrib/contenttype"
contrib_contenttype "github.com/dapr/components-contrib/contenttype"
"github.com/dapr/components-contrib/pubsub"
contrib_pubsub "github.com/dapr/components-contrib/pubsub"
"github.com/google/uuid"
jsoniter "github.com/json-iterator/go"
"google.golang.org/grpc/codes"
"google.golang.org/grpc/status"
"google.golang.org/protobuf/types/known/emptypb"
l8_comp_pubsub "mosn.io/layotto/components/pubsub"
dapr_v1pb "mosn.io/layotto/pkg/grpc/dapr/proto/runtime/v1"
"mosn.io/layotto/pkg/messages"
"mosn.io/pkg/log"
)

const (
Metadata_key_pubsubName = "pubsubName"
)

type Details struct {
metadata map[string]string
}

type TopicSubscriptions struct {
topic2Details map[string]Details
}

func (d *daprGrpcAPI) PublishEvent(ctx context.Context, in *dapr_v1pb.PublishEventRequest) (*emptypb.Empty, error) {
result, err := d.doPublishEvent(ctx, in.PubsubName, in.Topic, in.Data, in.DataContentType, in.Metadata)
if err != nil {
log.DefaultLogger.Errorf("[runtime] [grpc.PublishEvent] %v", err)
}
return result, err
}

func (d *daprGrpcAPI) doPublishEvent(ctx context.Context, pubsubName string, topic string, data []byte, contentType string, metadata map[string]string) (*emptypb.Empty, error) {
// 1. validate
if pubsubName == "" {
err := status.Error(codes.InvalidArgument, messages.ErrPubsubEmpty)
return &emptypb.Empty{}, err
}
if topic == "" {
err := status.Errorf(codes.InvalidArgument, messages.ErrTopicEmpty, pubsubName)
return &emptypb.Empty{}, err
}
// 2. get component
component, ok := d.pubSubs[pubsubName]
if !ok {
err := status.Errorf(codes.InvalidArgument, messages.ErrPubsubNotFound, pubsubName)
log.DefaultLogger.Errorf("[runtime] [grpc.PublishEvent] error: %v", err)
return &emptypb.Empty{}, err
}
// 3. new cloudevent request
if data == nil {
data = []byte{}
}
var envelope map[string]interface{}
var err error = nil
if contrib_contenttype.IsCloudEventContentType(contentType) {
envelope, err = contrib_pubsub.FromCloudEvent(data, topic, pubsubName, "")
if err != nil {
err = status.Errorf(codes.InvalidArgument, messages.ErrPubsubCloudEventCreation, err.Error())
return &emptypb.Empty{}, err
}
} else {
envelope = contrib_pubsub.NewCloudEventsEnvelope(uuid.New().String(), l8_comp_pubsub.DefaultCloudEventSource, l8_comp_pubsub.DefaultCloudEventType, "", topic, pubsubName,
contentType, data, "")
}
features := component.Features()
pubsub.ApplyMetadata(envelope, features, metadata)

b, err := jsoniter.ConfigFastest.Marshal(envelope)
if err != nil {
err = status.Errorf(codes.InvalidArgument, messages.ErrPubsubCloudEventsSer, topic, pubsubName, err.Error())
return &emptypb.Empty{}, err
}
// 4. publish
request := pubsub.PublishRequest{
PubsubName: pubsubName,
Topic: topic,
Data: b,
Metadata: metadata,
}

err = component.Publish(&request)
if err != nil {
nerr := status.Errorf(codes.Internal, messages.ErrPubsubPublishMessage, topic, pubsubName, err.Error())
return &emptypb.Empty{}, nerr
}
return &emptypb.Empty{}, nil
}

func (d *daprGrpcAPI) startSubscribing() error {
// 1. check if there is no need to do it
if len(d.pubSubs) == 0 {
return nil
}
// 2. list topics
topicRoutes, err := d.getInterestedTopics()
if err != nil {
return err
}
// return if no need to dosubscription
if len(topicRoutes) == 0 {
return nil
}
// 3. loop subscribe
for name, pubsub := range d.pubSubs {
if err := d.beginPubSub(name, pubsub, topicRoutes); err != nil {
return err
}
}
return nil
}

func (d *daprGrpcAPI) beginPubSub(pubsubName string, ps pubsub.PubSub, topicRoutes map[string]TopicSubscriptions) error {
// 1. call app to find topic topic2Details.
v, ok := topicRoutes[pubsubName]
if !ok {
return nil
}
// 2. loop subscribing every <topic, route>
for topic, route := range v.topic2Details {
// TODO limit topic scope
log.DefaultLogger.Debugf("[runtime][beginPubSub]subscribing to topic=%s on pubsub=%s", topic, pubsubName)
// ask component to subscribe
if err := ps.Subscribe(pubsub.SubscribeRequest{
Topic: topic,
Metadata: route.metadata,
}, func(ctx context.Context, msg *pubsub.NewMessage) error {
if msg.Metadata == nil {
msg.Metadata = make(map[string]string, 1)
}
msg.Metadata[Metadata_key_pubsubName] = pubsubName
return d.publishMessageGRPC(ctx, msg)
}); err != nil {
log.DefaultLogger.Warnf("[runtime][beginPubSub]failed to subscribe to topic %s: %s", topic, err)
return err
}
}
return nil
}

func (d *daprGrpcAPI) getInterestedTopics() (map[string]TopicSubscriptions, error) {
// 1. check
if d.topicPerComponent != nil {
return d.topicPerComponent, nil
}
if d.AppCallbackConn == nil {
return make(map[string]TopicSubscriptions), nil
}
comp2Topic := make(map[string]TopicSubscriptions)
var subscriptions []*dapr_v1pb.TopicSubscription

// 2. handle app subscriptions
client := dapr_v1pb.NewAppCallbackClient(d.AppCallbackConn)
subscriptions = listTopicSubscriptions(client, log.DefaultLogger)

// 3. prepare result
for _, s := range subscriptions {
if s == nil {
continue
}
if _, ok := comp2Topic[s.PubsubName]; !ok {
comp2Topic[s.PubsubName] = TopicSubscriptions{make(map[string]Details)}
}
comp2Topic[s.PubsubName].topic2Details[s.Topic] = Details{metadata: s.Metadata}
}

// 4. log
if len(comp2Topic) > 0 {
for pubsubName, v := range comp2Topic {
topics := []string{}
for topic := range v.topic2Details {
topics = append(topics, topic)
}
log.DefaultLogger.Infof("[runtime][getInterestedTopics]app is subscribed to the following topics: %v through pubsub=%s", topics, pubsubName)
}
}
// 5. cache the result
d.topicPerComponent = comp2Topic

return comp2Topic, nil
}

func (d *daprGrpcAPI) publishMessageGRPC(ctx context.Context, msg *pubsub.NewMessage) error {
// 1. Unmarshal to cloudEvent model
var cloudEvent map[string]interface{}
err := d.json.Unmarshal(msg.Data, &cloudEvent)
if err != nil {
log.DefaultLogger.Debugf("[runtime]error deserializing cloud events proto: %s", err)
return err
}

// 2. Drop msg if the current cloud event has expired
if pubsub.HasExpired(cloudEvent) {
log.DefaultLogger.Warnf("[runtime]dropping expired pub/sub event %v as of %v", cloudEvent[pubsub.IDField].(string), cloudEvent[pubsub.ExpirationField].(string))
return nil
}

// 3. Convert to proto domain struct
envelope := &dapr_v1pb.TopicEventRequest{
Id: cloudEvent[pubsub.IDField].(string),
Source: cloudEvent[pubsub.SourceField].(string),
DataContentType: cloudEvent[pubsub.DataContentTypeField].(string),
Type: cloudEvent[pubsub.TypeField].(string),
SpecVersion: cloudEvent[pubsub.SpecVersionField].(string),
Topic: msg.Topic,
PubsubName: msg.Metadata[Metadata_key_pubsubName],
}

// set data field
if data, ok := cloudEvent[pubsub.DataBase64Field]; ok && data != nil {
decoded, decodeErr := base64.StdEncoding.DecodeString(data.(string))
if decodeErr != nil {
log.DefaultLogger.Debugf("unable to base64 decode cloudEvent field data_base64: %s", decodeErr)
return err
}

envelope.Data = decoded
} else if data, ok := cloudEvent[pubsub.DataField]; ok && data != nil {
envelope.Data = nil

if contenttype.IsStringContentType(envelope.DataContentType) {
envelope.Data = []byte(data.(string))
} else if contenttype.IsJSONContentType(envelope.DataContentType) {
envelope.Data, _ = d.json.Marshal(data)
}
}

// 4. Call appcallback
clientV1 := dapr_v1pb.NewAppCallbackClient(d.AppCallbackConn)
res, err := clientV1.OnTopicEvent(ctx, envelope)

// 5. Check result
return retryStrategy(err, res, cloudEvent)
}

func retryStrategy(err error, res *dapr_v1pb.TopicEventResponse, cloudEvent map[string]interface{}) error {
if err != nil {
errStatus, hasErrStatus := status.FromError(err)
if hasErrStatus && (errStatus.Code() == codes.Unimplemented) {
// DROP
log.DefaultLogger.Warnf("[runtime]non-retriable error returned from app while processing pub/sub event %v: %s", cloudEvent[pubsub.IDField].(string), err)
return nil
}

err = errors.New(fmt.Sprintf("error returned from app while processing pub/sub event %v: %s", cloudEvent[pubsub.IDField].(string), err))
log.DefaultLogger.Debugf("%s", err)
// on error from application, return error for redelivery of event
return err
}

switch res.GetStatus() {
case dapr_v1pb.TopicEventResponse_SUCCESS:
return nil
case dapr_v1pb.TopicEventResponse_RETRY:
return errors.New(fmt.Sprintf("RETRY status returned from app while processing pub/sub event %v", cloudEvent[pubsub.IDField].(string)))
case dapr_v1pb.TopicEventResponse_DROP:
log.DefaultLogger.Warnf("[runtime]DROP status returned from app while processing pub/sub event %v", cloudEvent[pubsub.IDField].(string))
return nil
}
// Consider unknown status field as error and retry
return errors.New(fmt.Sprintf("unknown status returned from app while processing pub/sub event %v: %v", cloudEvent[pubsub.IDField].(string), res.GetStatus()))
}

func listTopicSubscriptions(client dapr_v1pb.AppCallbackClient, log log.ErrorLogger) []*dapr_v1pb.TopicSubscription {
resp, err := client.ListTopicSubscriptions(context.Background(), &emptypb.Empty{})
if err != nil {
log.Errorf("[runtime][listTopicSubscriptions]error after callback: %s", err)
return make([]*dapr_v1pb.TopicSubscription, 0)
}

if resp != nil && len(resp.Subscriptions) > 0 {
return resp.Subscriptions
}
return make([]*dapr_v1pb.TopicSubscription, 0)
}
Loading