Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the attempt at a general purpose (de)serializer by case statement with an extensible, customize-able, method based approach.
sort of fixes #16
This opens the door for a wider variety of orms and other object storage mechanisms to easily implement serialization, which will make fixing issues like #15 #14 much easier.
Custom serializers (or serializer overrides) are implemented by defining a pair of methods on a job called
serialize_<type>
. For example, the methods which handle Int32 are:These methods are declared in the abstract Job class, which means that they're override-able too, to your hearts content:
Serializing ORM models gets a little more complicated, but I think this will be a better abstraction. To match the current functionality, I'm including a Serializers::Granite module, which provides a macro to generate serializers for model classes. It's used like this:
serialize_granite_model(User)
generates these methods: