Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.27.0 support #25

Merged
merged 1 commit into from
Nov 25, 2018
Merged

0.27.0 support #25

merged 1 commit into from
Nov 25, 2018

Conversation

Blacksmoke16
Copy link
Contributor

@Blacksmoke16 Blacksmoke16 commented Nov 18, 2018

This fixes the epoch to unix breaking change. Also updates deps to the 0.27.0 releases as well.

Running make test throw this error tho

crystal run test/test_helper.cr test/**/*_test.cr -- --chaos
Module validation failed: !dbg attachment points at wrong subprogram for function
!10 = distinct !DISubprogram(name: "initialize", linkageName: "initialize", scope: !5, file: !5, line: 115, type: !6, isLocal: true, isDefinition: true, scopeLine: 115, isOptimized: false, unit: !0, variables: !2)
void (%"OpenSSL::BIO"*, %TCPSocket*)* @"*OpenSSL::BIO#initialize<TCPSocket>:Nil"
  %2 = call i8** @"~OpenSSL::BIO::CRYSTAL_BIO:read"(), !dbg !12
!12 = !DILocation(line: 14, column: 5, scope: !13)
!13 = distinct !DISubprogram(name: "set_data", linkageName: "set_data", scope: !5, file: !5, line: 13, type: !6, isLocal: true, isDefinition: true, scopeLine: 13, isOptimized: false, unit: !0, variables: !2)
!13 = distinct !DISubprogram(name: "set_data", linkageName: "set_data", scope: !5, file: !5, line: 13, type: !6, isLocal: true, isDefinition: true, scopeLine: 13, isOptimized: false, unit: !0, variables: !2)
 (Exception)
  from ???
  from ???
  from ???
  from ???
  from ???
  from ???
  from ???
  from ???
  from ???
Error: you've found a bug in the Crystal compiler. Please open an issue, including source code that will allow us to reproduce the bug: https://github.com/crystal-lang/crystal/issues
Makefile:7: recipe for target 'test' failed
make: *** [test] Error 1

So something is borked in the test portion of code. However, im not sue what it has to do with yet, maybe @robacarp has an idea? Anyway, mosquito will at least compile now.

@robacarp robacarp self-assigned this Nov 25, 2018
@robacarp
Copy link
Collaborator

@Blacksmoke16 thank you for this!

I was able to reproduce the compiler bug (known issue) causing the test suite to fail, and solve it by moving this line around in test_helper.cr:

require "minitest"
require "minitest/focus"
- require "minitest/autorun"

require "timecop"
Timecop.safe_mode = true

ENV["REDIS_URL"] = "redis://127.0.0.1:6379/3"

require "../mosquito"
require "./helpers/*"

Mosquito::Redis.instance.flushall
+ require "minitest/autorun"

Drop that line to the bottom and it should pass CI :D

@robacarp robacarp merged commit 087bf05 into mosquito-cr:master Nov 25, 2018
@Blacksmoke16 Blacksmoke16 deleted the 0.27.0-support branch November 25, 2018 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants