Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

declare_exchange in channel now timeout parameter to exchange.declare #120

Merged

Conversation

AndreasPresthammer
Copy link

@AndreasPresthammer AndreasPresthammer commented Apr 10, 2018

The timeout value for channel.declare_exchange(timeout) wasn't passed along to yield from exchange.declare()

@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.113% when pulling b550980 on AndreasPresthammer:ExchangeDeclareMissingTimeout into 38fd589 on mosquito:master.

1 similar comment
@coveralls
Copy link

coveralls commented Apr 10, 2018

Coverage Status

Coverage remained the same at 91.113% when pulling b550980 on AndreasPresthammer:ExchangeDeclareMissingTimeout into 38fd589 on mosquito:master.

@codecov-io
Copy link

codecov-io commented Apr 10, 2018

Codecov Report

Merging #120 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #120   +/-   ##
=======================================
  Coverage   87.58%   87.58%           
=======================================
  Files          20       20           
  Lines        1474     1474           
  Branches      141      141           
=======================================
  Hits         1291     1291           
  Misses        131      131           
  Partials       52       52
Impacted Files Coverage Δ
aio_pika/channel.py 92.34% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38fd589...b550980. Read the comment docs.

@mosquito mosquito merged commit 503aa54 into mosquito:master Apr 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants