Fixed Deprecation Warnings in Python 3.7 #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Python 3.7, the abstract base classes in `collections` must be imported from `collections.abc`
Codecov Report
@@ Coverage Diff @@
## master #153 +/- ##
=======================================
Coverage 72.12% 72.12%
=======================================
Files 35 35
Lines 5033 5033
Branches 554 554
=======================================
Hits 3630 3630
Misses 1156 1156
Partials 247 247
Continue to review full report at Codecov.
|
leenr
approved these changes
Dec 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using or importing abstract base classes from Python's
collectionsmodule, these must be explicitely used fromcollections.abcinstead of fromcollectionsdirectly. This commit solves the resulting DeprecationWarning.