Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The callback function can be a coroutine #52

Merged
merged 4 commits into from
Aug 14, 2017
Merged

The callback function can be a coroutine #52

merged 4 commits into from
Aug 14, 2017

Conversation

iselind
Copy link
Contributor

@iselind iselind commented Aug 14, 2017

No description provided.

The documentation is unclear whether on_message can be a coroutine or not. Adding an example to illustrate the possibility.
@coveralls
Copy link

coveralls commented Aug 14, 2017

Coverage Status

Coverage remained the same at 92.327% when pulling e9bf163 on iselind:iselind-patch-1 into 1992d2e on mosquito:master.

@coveralls
Copy link

coveralls commented Aug 14, 2017

Coverage Status

Coverage remained the same at 92.327% when pulling 616930f on iselind:iselind-patch-1 into 1992d2e on mosquito:master.

@coveralls
Copy link

coveralls commented Aug 14, 2017

Coverage Status

Coverage remained the same at 92.327% when pulling 68f2619 on iselind:iselind-patch-1 into 1992d2e on mosquito:master.

@mosquito
Copy link
Owner

Great work. Thank you.

@mosquito mosquito merged commit 89bdfc7 into mosquito:master Aug 14, 2017
@mosquito
Copy link
Owner

Your changes was applied to release 0.19.0.

@iselind
Copy link
Contributor Author

iselind commented Aug 14, 2017

Thanks, when will the docs at https://aio-pika.readthedocs.io/en/latest/rabbitmq-tutorial/1-introduction.html be regenerated?

@mosquito
Copy link
Owner

@iselind as soon as readthedocs will made it.

@mosquito
Copy link
Owner

BTW: I found some issues with line numbers in rst-file. But I already fix it.

@iselind
Copy link
Contributor Author

iselind commented Aug 14, 2017

Ops, very sorry i missed that!

mosquito added a commit that referenced this pull request Jan 5, 2018
The callback function can be a coroutine
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants