Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pika version to 0.11 #53

Merged
merged 4 commits into from
Aug 30, 2017
Merged

Conversation

decaz
Copy link
Collaborator

@decaz decaz commented Aug 30, 2017

No description provided.

@coveralls
Copy link

coveralls commented Aug 30, 2017

Coverage Status

Coverage decreased (-0.3%) to 92.072% when pulling a7292ba on decaz:feature/pika-0.11 into 8efddcf on mosquito:master.

@mosquito
Copy link
Owner

Hi @decaz please bump the aio-pika's version

@coveralls
Copy link

coveralls commented Aug 30, 2017

Coverage Status

Coverage decreased (-0.3%) to 92.072% when pulling d5c06a0 on decaz:feature/pika-0.11 into 8efddcf on mosquito:master.

@coveralls
Copy link

coveralls commented Aug 30, 2017

Coverage Status

Coverage decreased (-0.3%) to 92.072% when pulling d6a2ed5 on decaz:feature/pika-0.11 into 8efddcf on mosquito:master.

@decaz
Copy link
Collaborator Author

decaz commented Aug 30, 2017

@mosquito done!

@mosquito
Copy link
Owner

mosquito commented Aug 30, 2017

@decaz in the pika's 0.11 history was added asyncio connection-adapter based on my implementation.

As a complete solution we are have to remove redundant code from aio-pika.

Can you try to do it?

@mosquito
Copy link
Owner

@decaz I guess the simplest solution is remove IOLoopAdapter and inherit pika's connection adapter only for set client_properties

@coveralls
Copy link

coveralls commented Aug 30, 2017

Coverage Status

Coverage increased (+2.01%) to 94.342% when pulling f9f4d0c on decaz:feature/pika-0.11 into 8efddcf on mosquito:master.

@decaz
Copy link
Collaborator Author

decaz commented Aug 30, 2017

@mosquito I agree, added some changes.

setup.py Outdated
@@ -10,7 +10,7 @@

requires = [
'shortuuid',
'pika<0.11',
'pika<0.12',
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and >=0.11 is required now.

Copy link
Collaborator Author

@decaz decaz Aug 30, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mosquito fixed.

@coveralls
Copy link

coveralls commented Aug 30, 2017

Coverage Status

Coverage increased (+2.01%) to 94.342% when pulling 7aa8fc8 on decaz:feature/pika-0.11 into 8efddcf on mosquito:master.

@mosquito mosquito merged commit 9de9120 into mosquito:master Aug 30, 2017
@mosquito
Copy link
Owner

Excellent. Thank you for your contribution.

@mosquito
Copy link
Owner

mosquito commented Sep 7, 2017

The #54 stops reproduction after revert to pika-0.10.

I have to revert this changes. I can't imagine test-case for this and I have to watch similar pika's issues.

I'm sorry.

@mosquito
Copy link
Owner

mosquito commented Sep 7, 2017

Actually you can use 0.20.x releases. 😁

mosquito added a commit that referenced this pull request Jan 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants