no wait bytes with asyncio.wait_for for each frame #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
decaz
reviewed
Dec 13, 2022
| @@ -137,10 +137,8 @@ async def close( | |||
| if self.is_closed: | |||
| return None | |||
|
|
|||
| await asyncio.wait_for( | |||
| self.loop.create_task(self.__closer(exc)), | |||
There was a problem hiding this comment.
Here should not have been task and await asyncio.wait_for(self.__closer(exc), timeout) was enough, am I right?
mosquito
force-pushed
the
hotfix/issue-156
branch
from
d1158de
to
784dda9
Compare
|
@dgoeries could you make sure that the code from this branch fixes this monstrous performance drop? |
|
@mosquito this fixes most of it thanks!. With this PR i have around 5.9-6kHz message consumption. |
|
I ran again. Now i barely see a difference, must have had a bad period when comparing. |
|
Yeah, it seems that the 3.3.1 version is slightly more performing (~5%) in message consumption. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #156