Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete quoting for parameters of some CMake commands #47

Closed
elfring opened this issue Jul 29, 2018 · 1 comment
Closed

Complete quoting for parameters of some CMake commands #47

elfring opened this issue Jul 29, 2018 · 1 comment

Comments

@elfring
Copy link

elfring commented Jul 29, 2018

Some parameters (like “${CMAKE_CURRENT_BINARY_DIR}/configure.h”) are passed to CMake commands in your build scripts without enclosing them by quotation marks. I see that these places will result in build difficulties if the contents of the used variables will contain special characters like semicolons.

I would recommend to apply advices from a wiki article.

@mosra
Copy link
Owner

mosra commented Jul 29, 2018

You opened this exact issue five years ago on the magnum repository, don't you remember? ;) Because I do: mosra/magnum#24

If you look at your issue from 2013, there I proved that quoting is not necessary — CMake is not Unix shell, it will correctly preserve the space in variable substitutions. And to answer your second question from there — no, I don't plan bothering with paths containing semicolons. Unlike spaces, that's too hard to fix and not worth spending time with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants