Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microptimize some buffer protocol and vector funcs #15

Closed
wants to merge 3 commits into from

Conversation

Skylion007
Copy link
Contributor

  • Noticed some unnecessary copies in the templated lambdas, pytype objects aren't trivially copyable so it's better to pass them by reference here.

* Noticed some unnecessary copies
Copy link
Owner

@mosra mosra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

src/python/magnum/math.vector.h Outdated Show resolved Hide resolved
@mosra mosra added this to the 2022.0a milestone Apr 21, 2022
@mosra mosra added this to TODO in Python via automation Apr 21, 2022
Skylion007 and others added 2 commits April 21, 2022 11:19
Co-authored-by: Vladimír Vondruš <mosra@centrum.cz>
@Skylion007 Skylion007 changed the title Microptimize some math vector funcs Microptimize some buffer protocol and vector funcs Apr 21, 2022
@codecov
Copy link

codecov bot commented Apr 22, 2022

Codecov Report

Merging #15 (8809a25) into master (0510bdf) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #15   +/-   ##
=======================================
  Coverage   91.24%   91.24%           
=======================================
  Files          43       43           
  Lines        4535     4535           
=======================================
  Hits         4138     4138           
  Misses        397      397           
Impacted Files Coverage Δ
src/python/corrade/containers.cpp 85.71% <100.00%> (ø)
src/python/magnum/math.matrix.h 93.22% <100.00%> (ø)
src/python/magnum/math.vector.h 98.58% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0510bdf...8809a25. Read the comment docs.

@mosra
Copy link
Owner

mosra commented Apr 23, 2022

Merged as ca5e16f, thanks!

@mosra mosra closed this Apr 23, 2022
Python automation moved this from TODO to Done Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Python
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants