Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor clang-tidy fixups in some of the "next" magnum-bindings #16

Merged

Conversation

Skylion007
Copy link
Contributor

Apply some minor perf/correctness improvement to the next-bindings:

  • Don't pass by value unused variables
  • Explicitly default empty virtual dtor constructors. This allows the optimizer to be more aggressive in optimizing them.

@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Merging #16 (f22d377) into next (732a0b7) will not change coverage.
The diff coverage is 66.66%.

@@           Coverage Diff           @@
##             next      #16   +/-   ##
=======================================
  Coverage   91.18%   91.18%           
=======================================
  Files          45       45           
  Lines        4709     4709           
=======================================
  Hits         4294     4294           
  Misses        415      415           
Impacted Files Coverage Δ
src/python/magnum/platform/cgl.cpp 61.53% <0.00%> (ø)
src/python/magnum/platform/glfw.cpp 36.84% <0.00%> (ø)
src/python/magnum/platform/glx.cpp 61.53% <0.00%> (ø)
src/python/magnum/gl.cpp 95.10% <100.00%> (ø)
src/python/magnum/platform/egl.cpp 76.92% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mosra mosra added this to the 2022.0a milestone Sep 14, 2022
@mosra mosra added this to TODO in Python via automation Sep 14, 2022
@mosra mosra changed the base branch from next to master September 14, 2022 16:14
@mosra mosra merged commit f22d377 into mosra:master Sep 14, 2022
Python automation moved this from TODO to Done Sep 14, 2022
@mosra
Copy link
Owner

mosra commented Sep 14, 2022

Thank you!

@Skylion007 Skylion007 deleted the next-clang-tidy-fixups-dtor-PyWindowless branch September 14, 2022 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Python
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants