Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python: expose GL::Renderer::setBlendEquation(), GL::Renderer::setBlendFunction() and related enums. #9

Closed
wants to merge 1 commit into from

Conversation

vladimirgamalyan
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2020

Codecov Report

Merging #9 into master will increase coverage by 0.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #9      +/-   ##
==========================================
+ Coverage   90.95%   91.08%   +0.13%     
==========================================
  Files          40       40              
  Lines        4122     4005     -117     
==========================================
- Hits         3749     3648     -101     
+ Misses        373      357      -16     
Impacted Files Coverage Δ
src/python/magnum/gl.cpp 96.01% <100.00%> (+0.29%) ⬆️
src/python/magnum/platform/application.h 68.75% <0.00%> (-23.28%) ⬇️
src/python/magnum/platform/glx.cpp 55.55% <0.00%> (-11.12%) ⬇️
src/python/magnum/magnum.cpp 100.00% <0.00%> (ø)
src/python/corrade/corrade.cpp 100.00% <0.00%> (ø)
src/python/magnum/platform/sdl2.cpp 36.95% <0.00%> (+4.22%) ⬆️
src/python/magnum/platform/glfw.cpp 35.71% <0.00%> (+5.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11075a4...5409380. Read the comment docs.

@mosra mosra added this to the 2020.0b milestone Oct 6, 2020
@mosra mosra added this to TODO in Python via automation Oct 6, 2020
@mosra
Copy link
Owner

mosra commented Oct 6, 2020

Merged as fe559e6, thank you! In addition I also exposed the remaining overloads of those + all new features that went into shaders.Phong since last time (instancing, improved normal mapping and light support...)

@mosra mosra closed this Oct 6, 2020
Python automation moved this from TODO to Done Oct 6, 2020
@vladimirgamalyan vladimirgamalyan deleted the patch-1 branch November 6, 2020 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Python
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants