Mac Angle #3
Mac Angle #3
Conversation
|
Not quite understanding why |
|
Ok so maybe you need to enable https://github.com/hsdk123/magnum-ci/actions on your fork and it'll appear there? |
.github/workflows/mac.xml
Outdated
| strategy: | ||
| matrix: | ||
| target: ["mac"] | ||
| env: | ||
| # "If you are a non-googler you need to set DEPOT_TOOLS_WIN_TOOLCHAIN=0" | ||
| DEPOT_TOOLS_WIN_TOOLCHAIN: 0 | ||
| # Bump this to fetch a newer version | ||
| ANGLE_VERSION: 4134 | ||
| steps: | ||
| - uses: actions/checkout@v1 | ||
| - name: Clone | ||
| run: | | ||
| git clone --depth=1 --branch chromium/${{ env.ANGLE_VERSION }} https://chromium.googlesource.com/angle/angle | ||
| - name: Set up Python 2.7 | ||
| uses: actions/setup-python@v1 | ||
| with: | ||
| python-version: 2.7 | ||
| - name: Dependencies | ||
| run: | | ||
| Invoke-WebRequest https://storage.googleapis.com/chrome-infra/depot_tools.zip -O depot_tools.zip | ||
| 7z x depot_tools.zip -o${{ github.workspace }}/depot_tools | ||
| echo "::add-path::${{ github.workspace }}\depot_tools" | ||
| - name: Configure | ||
| run: | | ||
| mkdir angle\out | ||
| mkdir angle\out\Release | ||
| copy args-${{ matrix.target }}.gn angle\out\Release\args.gn | ||
| - name: Generate | ||
| run: | | ||
| cd angle | ||
| python scripts/bootstrap.py | ||
| gclient.bat sync | ||
| git checkout master | ||
| gn gen out/Release | ||
| - name: Build | ||
| run: | | ||
| cd angle | ||
| autoninja -C out/Release libEGL libGLESv2 | ||
| - name: Install | ||
| run: | | ||
| mkdir install | ||
| mkdir install\lib | ||
| mkdir install\bin | ||
| mkdir install\include | ||
|
|
||
| copy angle\out\Release\d3dcompiler_47.dll install\bin\ | ||
| copy angle\out\Release\libGLESv2.dll.lib install\lib\libGLESv2.lib | ||
| copy angle\out\Release\libGLESv2.dll install\bin\ | ||
| copy angle\out\Release\libEGL.dll.lib install\lib\libEGL.lib | ||
| copy angle\out\Release\libEGL.dll install\bin\ | ||
| xcopy /e angle\include\* install\include\ | ||
| - name: Upload artifacts | ||
| uses: actions/upload-artifact@v1 | ||
| with: | ||
| name: angle-${{ env.ANGLE_VERSION }}-${{ matrix.target }} | ||
| path: install |
There was a problem hiding this comment.
Seems that the whole workflow gets ignored if there's some error. I'd remove all this and add just
steps:
- name: hello
run: |
echo helloat first, then expanding it further
There was a problem hiding this comment.
Hmm... I've tried updating the file to a more minimal version and I still can't seem to see it reflected in this PR...
There was a problem hiding this comment.
Not here (I suppose because it runs only the workflows that are already on upstream), but I see it here: https://github.com/hsdk123/magnum-ci/actions/runs/156944912
There was a problem hiding this comment.
Change the name back to Angle so it's together with the windows jobs?
There was a problem hiding this comment.
This might sound a bit weird, but it looks as if you need to
a. go into actions
b. create a new workflow file through there
to be able to start getting that workflow file to trigger.
If you just upload a new .yml file to the repo, it seems it doesn't get registered.
Would you happen to be able to create a mac.yml file in the repo?
I'll try just editing that file and see what happens.
There was a problem hiding this comment.
The workflow run says "This commit does not belong to any branch on this repository."
I don't know, your comment:
Ok so maybe you need to enable https://github.com/hsdk123/magnum-ci/actions on your fork and it'll appear there?
... sounded pretty sane to me. I think initially you need to run this through your own pipeline until it's merged. Would make sense, otherwise you could go around and steal people's CI minutes :D
There was a problem hiding this comment.
Would make sense, otherwise you could go around and steal people's CI minutes :D
Makes sense, although in that case, I'm not sure what I should be doing now. It seems the only way I can get a workflow to trigger on even my fork is to add the yml through the action tab, and if I do so, it only allows me to add the file in either the master branch, or a completely new branch, thus not the angle branch which we're working on.
This all seems terribly roundabout to me.
|
On a side note, seems I've managed to get something up and running: https://github.com/hsdk123/magnum-ci/runs/835679187?check_suite_focus=true Seems like we now only need to figure out the weirdnesses of getting a workflow registered. |
|
Wow, already? :D Wonderful. The ZIP seems to contain everything needed, great. |
|
I took your files and commited that as 93e40b4, seems to be working. Though for some reason it's listed as two different workflows, I guess I'd need to merge those two files together somehow? Whatever. This does the job, and that's all that matters. Thanks for setting this up. |
No description provided.