Skip to content

Commit

Permalink
Test: expect test failure with XFB and EXT_debug_label.
Browse files Browse the repository at this point in the history
The extension spec says it should be allowed, but NV thinks otherwise.
  • Loading branch information
mosra committed Jan 10, 2018
1 parent 2912a62 commit 1f2849d
Showing 1 changed file with 18 additions and 3 deletions.
21 changes: 18 additions & 3 deletions src/Magnum/Test/TransformFeedbackGLTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -188,12 +188,27 @@ void TransformFeedbackGLTest::label() {
TransformFeedback feedback;

CORRADE_COMPARE(feedback.label(), "");
MAGNUM_VERIFY_NO_ERROR();
{
#ifdef MAGNUM_TARGET_GLES
CORRADE_EXPECT_FAIL_IF(Context::current().detectedDriver() & Context::DetectedDriver::NVidia &&
!Context::current().isExtensionSupported<Extensions::GL::KHR::debug>(),
"NVidia 387.34 ES3.2 complains that GL_TRANSFORM_FEEDBACK can't be used with glGetObjectLabelEXT().");
#endif
MAGNUM_VERIFY_NO_ERROR();
}

feedback.setLabel("MyXfb");
MAGNUM_VERIFY_NO_ERROR();
{
#ifdef MAGNUM_TARGET_GLES
CORRADE_EXPECT_FAIL_IF(Context::current().detectedDriver() & Context::DetectedDriver::NVidia &&
!Context::current().isExtensionSupported<Extensions::GL::KHR::debug>(),
"NVidia 387.34 ES3.2 complains that GL_TRANSFORM_FEEDBACK can't be used with glGetObjectLabelEXT().");
#endif
MAGNUM_VERIFY_NO_ERROR();

CORRADE_COMPARE(feedback.label(), "MyXfb");
CORRADE_COMPARE(feedback.label(), "MyXfb");
MAGNUM_VERIFY_NO_ERROR(); /* Check for errors again to flush the error state */
}
}

namespace {
Expand Down

0 comments on commit 1f2849d

Please sign in to comment.