Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out how to bundle 3rd party Find modules #436

Open
fran6co opened this issue Apr 29, 2020 · 2 comments
Open

Figure out how to bundle 3rd party Find modules #436

fran6co opened this issue Apr 29, 2020 · 2 comments

Comments

@fran6co
Copy link

fran6co commented Apr 29, 2020

Trying to follow the documentation for when Magnum was externally built and installed and I can't get it to work. Magnum compiles just fine but then it doesn't copy all the FindXXX.cmake files to the install folder. That causes the FindMagnum.cmake to fail when it tries to find_package(GLFW). I think the fix would be to add them to the install as well, but I might be doing something wrong.

It warns that it can't find GLFW in this line => https://github.com/mosra/magnum/blob/master/modules/FindMagnum.cmake#L632

and then it fails later when it tries to find GLFW::GLFW

I believe the fix would be to just add the rest of the find cmakes to https://github.com/mosra/magnum/blob/master/modules/CMakeLists.txt but given that file hasn't been changed for a long time it makes me think that I'm doing something wrong instead

@fran6co fran6co changed the title Can't find FindGLFX.cmake in externally built Magnum Can't find FindGLFW.cmake in externally built Magnum Apr 29, 2020
@mosra
Copy link
Owner

mosra commented Apr 29, 2020

Hi!

Installing the extra FindGLFW, FindOpenAL, ... modules system-wide is problematic, because those could cause conflicts with Find modules of other libraries (to my knowledge there's at least five different mutually incompatible FindSDL2.cmake modules in the wild, for example). Figuring out a better way to handle these is on my TODO list for the next release (#411), but currently the designated way to do this is copying those by hand to the modules/ directory of your app (assuming you started with the bootstrap project).

Hope this helps :)

@fran6co
Copy link
Author

fran6co commented Apr 30, 2020

Thanks for the quick response. I thought I was just missing something obvious, thanks!

@mosra mosra added this to the 2020.0b milestone Jun 26, 2020
@mosra mosra added this to TODO in Project management via automation Jun 26, 2020
@mosra mosra changed the title Can't find FindGLFW.cmake in externally built Magnum Figure out how to bundle 3rd party Find modules Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants