-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[magnum/magnum-plugins] fix magnum-plugins building all magnum dependencies #16657
Conversation
@fran6co, thanks for the PR! could you update the baseline version?
|
0845f65
to
2ebfb1a
Compare
@PhoebeHui done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your updates!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't, we deliberately use @fran6co may I ask where did you get this error? Was it during the package build or when using the magnum-plugins vcpkg package in your project? (@ras0219-msft thanks a lot for the ping, is there some automated way to have @Squareys and me pinged on magnum package updates? It could save us a lot of time. Maybe through some CODEOWNERS file?) |
@mosra it happens when I'm using magnum-plugins. When I add the project with this:
I get this error:
If I add the alias of
|
Maybe the proper solution would be adding to the installation MagnumPlugins's FindAssimp.cmake as it's not being copied as part of the package |
Ah, I remember an older issue opened by you as well, coincidentally: mosra/magnum#436 For the reasons stated there, the solution (until I get this finally fixed) is to copy The same behavior is with most other 3rd party dependencies in Magnum, so I don't think doing a patch inside vcpkg makes sense. |
Ah, forgot about that... Well, I guess I can do the same, I'll remove the assimp change but keep the [core] change to avoid installing all magnum dependencies |
2ebfb1a
to
87ebc1a
Compare
87ebc1a
to
f302925
Compare
Missed this one completely. Good idea 👍 I'll ping you once mosra/magnum#436 gets fixed properly in Magnum itself :) |
I think CODEOWNERS won't work due to write permissions, but we do have a |
LGTM, thanks everyone! |
Describe the pull request
Fixes error:
The assimp library in vcpkg is all lower case and Magnum expects it camel case.
Also installing magnum-plugins triggers the installation of all the features in magnum.