Fixes to recent PlayableGroup and Listener #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Any empty group would result in application crash. Signed-off-by: Squareys <Squareys@googlemail.com>
When PlayableGroup.h is used without Playable.h, the compiler spits out a very unintuitive error message, which would probably confuse unfamiliar users. This change fixes that error message appearing. Signed-off-by: Squareys <Squareys@googlemail.com>
|
Merged. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @mosra !
I just started using my recent contribution to MagnumAudio myself and immediately found two bugs (very bad omen): Listener would crash if passed a empty playable group on update and PlayableGroup.h produces some weird compile errors when Playable.h is not included aswell.
This PR provides fixes for both issues.
Greetings, Squareys