Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't force static for Android #617

Closed
wants to merge 1 commit into from
Closed

Don't force static for Android #617

wants to merge 1 commit into from

Conversation

bansan85
Copy link
Contributor

Related to mosra/corrade#170

@bansan85
Copy link
Contributor Author

libMagnumEglContext is still forced to static. flextGLInit is not an exported symbol.

@mosra mosra added this to the 2023.0a milestone Apr 27, 2023
@mosra mosra added this to TODO in Platforms via automation Apr 27, 2023
@mosra
Copy link
Owner

mosra commented Apr 27, 2023

Amazing, thanks for updating and testing this side as well 👍

libMagnumEglContext is still forced to static

Yes, those are deliberately static everywhere always since they're extremely tiny and are meant to be only used from the top-level application executable/library to initialize GL, and from nowhere else after that. Given that usage pattern, so far there weren't any problems with that, but of course let me know if your use case would be different.

@bansan85
Copy link
Contributor Author

In my case, it works well. But EGL is used by only one of my shared libraries.

@mosra
Copy link
Owner

mosra commented Jul 23, 2023

Merged as a9898a0, sorry for the delay. The MAGNUM_BUILD_PLUGINS_STATIC is however still forced on Android, because the PluginManager itself doesn't have any support for loading dynamic libraries there. It'd need to get implemented in it first. I think it's not as much of a problem for the plugins, since they're relatively small and don't contain any shared mutable global state that could cause problems.

I also mirrored this change in other repos as mosra/magnum-plugins@127a9ec, mosra/magnum-extras@f567dba and mosra/magnum-integration@35c05fd.

Thank you!

@mosra mosra closed this Jul 23, 2023
Platforms automation moved this from TODO to Done Jul 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Platforms
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants