This repository has been archived by the owner on Oct 21, 2021. It is now read-only.
Code cleanup #6
Closed
Code cleanup #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch changes indentation all over the source code so it's more consistent and also removes some unnecessary else statements in order to decrease indentation level where unnecessary. Signed-off-by: Felipe Balbi <balbi@kernel.org>
source exits early if 'dev' can't be found, so by the time we reach libusb_close(), we're sure dev is valid pointer. Signed-off-by: Felipe Balbi <balbi@kernel.org>
All other error cases, return -1, so fix this one case where it's returning 1 instead. Signed-off-by: Felipe Balbi <balbi@kernel.org>
fix indentation and spaces around the source code. Signed-off-by: Felipe Balbi <balbi@kernel.org>
This just helps with readability, no functional changes. while at that, also add a blank line between declarations and code, also remove a blank line before close-curly-brackets. Signed-off-by: Felipe Balbi <balbi@kernel.org>
If we do a pre-increment, we will never look at device 0, only 1 and all others. By doing a post-increment, we will also look at device 0. Signed-off-by: Felipe Balbi <balbi@kernel.org>
cleanup only, no functional changes. Signed-off-by: Felipe Balbi <balbi@kernel.org>
indentation, white spaces, and the like. Signed-off-by: Felipe Balbi <balbi@kernel.org>
indentation, whitespaces, and the like. Signed-off-by: Felipe Balbi <balbi@kernel.org>
they're not needed and we can decrease indentation with this. Signed-off-by: Felipe Balbi <balbi@kernel.org>
dev is always valid when that call happens. Signed-off-by: Felipe Balbi <balbi@kernel.org>
return -1 instead of 1. Signed-off-by: Felipe Balbi <balbi@kernel.org>
return is not a function, so remove () around its return value, return negative value on error, indentation. Signed-off-by: Felipe Balbi <balbi@kernel.org>
|
Thank you for your contribution, but we haven't looked at Daisho in quite a while. I'm closing this PR and archiving the repo. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clean up daisho a bit so code is slightly more readable. Compile-tested only due to lack of HW.