fix code smells for codeclimate

mostafamaklad · Mar 17, 2018 · 229b1bc · 229b1bc
1 parent bc76fe8
commit 229b1bc
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/Traits/HasRoles.php b/src/Traits/HasRoles.php
@@ -172,7 +172,7 @@ public function hasRole($roles): bool
                     break;
                 }
             }
-        } else {
+        } elseif($roles instanceof Collection) {
             $hasRole = ! $roles->intersect($this->roles)->isEmpty();
         }
 
@@ -208,7 +208,7 @@ public function hasAllRoles($roles): bool
             $hasRoles = $this->roles->contains('name', $roles);
         } elseif ($roles instanceof Role) {
             $hasRoles = $this->roles->contains('id', $roles->id);
-        } else {
+        } elseif(\is_array($roles) || $roles instanceof Collection) {
             $roles = \collect()->make($roles)->map(function ($role) {
                 return $role instanceof Role ? $role->name : $role;
             });