Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recreate Exceptions #23

Merged
merged 4 commits into from
Sep 7, 2017
Merged

Recreate Exceptions #23

merged 4 commits into from
Sep 7, 2017

Conversation

mostafamaklad
Copy link
Owner

Description

Recreate Exceptions and Reorganize the code

Motivation and context

Resolve some Mess Detection errors and Code Sniffer Errors

How has this been tested?

composer test
phpcs --standard=psr2 --report-file=build/phpcs.txt src/

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the CONTRIBUTING document.
  • My pull request addresses exactly one patch/feature.
  • I have created a branch for this patch/feature.
  • Each individual commit in the pull request is meaningful.
  • I have added tests to cover my changes.
  • If my change requires a change to the documentation, I have updated it accordingly.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 3c75e54 on v1.2 into 216e6b1 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling dbe1877 on v1.2 into 216e6b1 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling a6d99d9 on v1.2 into 216e6b1 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 4b02188 on v1.2 into 216e6b1 on master.

@mostafamaklad mostafamaklad merged commit bdbf5d9 into master Sep 7, 2017
mostafamaklad added a commit that referenced this pull request Mar 21, 2018
sloan58 referenced this pull request in sloan58/laravel-permission-mongodb Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants