Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code smells in code climate #54

Merged
merged 3 commits into from
Mar 23, 2018
Merged

Fix code smells in code climate #54

merged 3 commits into from
Mar 23, 2018

Conversation

mostafamaklad
Copy link
Owner

Description

Fix code smells in code climate

How has this been tested?

composer test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the CONTRIBUTING document.
  • My pull request addresses exactly one patch/feature.
  • I have created a branch for this patch/feature.
  • Each individual commit in the pull request is meaningful.
  • I have added tests to cover my changes.
  • If my change requires a change to the documentation, I have updated it accordingly.

If you're unsure about any of these, don't hesitate to ask. We're here to help!

@coveralls
Copy link

coveralls commented Mar 23, 2018

Coverage Status

Coverage decreased (-0.01%) to 99.451% when pulling 4dbe81b on v1.7 into b8bfbfd on master.

@mostafamaklad mostafamaklad merged commit 9683593 into master Mar 23, 2018
mostafamaklad added a commit that referenced this pull request Feb 24, 2020
Fix code smells in code climate
sloan58 referenced this pull request in sloan58/laravel-permission-mongodb Feb 7, 2024
Fix code smells in code climate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants