Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code quality #8

Merged
merged 3 commits into from
Aug 30, 2017
Merged

Code quality #8

merged 3 commits into from
Aug 30, 2017

Conversation

mostafamaklad
Copy link
Owner

@mostafamaklad mostafamaklad commented Aug 30, 2017

Description

Remove PHP 7.2 from testing Travis.

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the CONTRIBUTING document.
  • My pull request addresses exactly one patch/feature.
  • I have created a branch for this patch/feature.
  • Each individual commit in the pull request is meaningful.
  • I have added tests to cover my changes.
  • If my change requires a change to the documentation, I have updated it accordingly.

If you're unsure about any of these, don't hesitate to ask. We're here to help!

…ssion-mongodb into code-quality

* 'code-quality' of github.com:mostafamaklad/laravel-permission-mongodb:
  Apply fixes from StyleCI
@mostafamaklad mostafamaklad merged commit 5c1b006 into master Aug 30, 2017
mostafamaklad added a commit that referenced this pull request Mar 21, 2018
sloan58 referenced this pull request in sloan58/laravel-permission-mongodb Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants