Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Natural ventilation implementation to HBZone class #239

Closed
mostaphaRoudsari opened this issue Dec 31, 2014 · 2 comments
Closed

Natural ventilation implementation to HBZone class #239

mostaphaRoudsari opened this issue Dec 31, 2014 · 2 comments

Comments

@mostaphaRoudsari
Copy link
Member

Hi @chriswmackey, We need to add all the new properties for natural ventilation to HBZone class and also re-evaluateHBZone. It is missing right now.

In general a good practice is to remove all the direct assignments and write set/get methods for the properties.

http://www.grasshopper3d.com/xn/detail/2985220:Comment:1197226

@mostaphaRoudsari
Copy link
Member Author

It was already there and overwritten in one of the recent commits. It is fixed now!

@chriswmackey
Copy link
Member

Awesome. Good to know. For general reference, all of the nat vent attributes that I added are lists that are introduced in the init part of the HBZone class. The components that add nat vent features just add things to the lists and the Run EnergyPlus component just takes the content of these lists and writes them into the IDF. I don't think that I need to write anything into re-evaluateHBZone but, if you think otherwise, just let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants