Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong units in radiation analysis component outputs description #62

Closed
mostaphaRoudsari opened this issue May 22, 2014 · 5 comments
Closed

Comments

@mostaphaRoudsari
Copy link
Member

http://www.grasshopper3d.com/xn/detail/2985220:Comment:1073935

"The RadiationAnalysis component mentions it returns values in Wh/m2 and Wh, but the generated legend says kWh/m2. The latter seems to be right."

@chriswmackey this is actually half true. If the sky is generated for a single HOY the result will be in Wh/m2. In case of annual sky the values will be kWh/m2. I'm not sure how do we want to manage this?

@chriswmackey
Copy link
Member

Oh gosh. I had experienced this problem before but forgot to post it. I
think that we should put a conversion factor for the cases where we get
Wh/m2 in order to make things consistent. I set all of the E+ results to
be in kWh so I think it is worthwhile making kWh a standard across all
analysis components. I'll try to get to this and fix the description
sometime this weekend unless you get to it first, Mostapha.

-Chris

On Wed, May 21, 2014 at 9:09 PM, Mostapha Sadeghipour Roudsari <
notifications@github.com> wrote:

http://www.grasshopper3d.com/xn/detail/2985220:Comment:1073935

"The RadiationAnalysis component mentions it returns values in Wh/m2 and
Wh, but the generated legend says kWh/m2. The latter seems to be right."

@chriswmackey https://github.com/chriswmackey this is actually half
true. If the sky is generated for a single HOY the result will be in Wh/m2.
In case of annual sky the values will be kWh/m2. I'm not sure how do we
want to manage this?


Reply to this email directly or view it on GitHubhttps://github.com//issues/62
.

mostaphaRoudsari added a commit that referenced this issue Jul 8, 2014
@mostaphaRoudsari
Copy link
Member Author

For some reason it is back! http://www.grasshopper3d.com/group/ladybug/forum/topics/one-doubt-about-radiation-data

Can you take care of this once more @chriswmackey? Thanks.

@chriswmackey chriswmackey added this to the January 2015 Release milestone Jan 22, 2015
@chriswmackey
Copy link
Member

@mostaphaRoudsari , I take a look into it and have it taken care of for the release. I think that we each thought that the other was going to fix the issue and neither of us ended up addressing it.

@mostaphaRoudsari
Copy link
Member Author

@chriswmackey thanks!

@chriswmackey
Copy link
Member

Hello Everyone,
This is now fixed. The selected sky matrices now appear in kWh.
rad in kwh

Enjoy!
-Chris

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants