build(configuration): module property within package.json
#8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm trying to create a bundled file so it can be served to the browser. My `tsconfig.json` `module` and `target` fields configured to `commonjs` (module code generation) and `es5`. I removed the `module` field locally within my `node_modules` folder and the end footprint is `es5` as i configured through my own `tsconfig.json`.
|
@TylorS ping (: |
|
Thanks for pinging me @nissoh, this had gotten away from me. I've realized in some of my newer projects, but hadn't gotten back to making adjustments here. The "proper" fix, is to make an adjustment to the tsconfig.json's target field. It needs to be changed to |
added 3 commits
February 21, 2017 09:35
undo remove of property field 'module', tsconfig target changed from es2015 to es5
… package-config
|
Fixed with v3.3.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to create a bundled file so it can be served to the browser.
my final bundle ends up with es2015 code which cannot run in older versions of chrome, ff, IE.
is it being forced because of the module property?
My
tsconfig.jsonmoduleandtargetfields configured tocommonjs(module code generation)and
es5. I removed themodulefield locally within mynode_modulesfolder and the endfootprint is
es5as i configured through my owntsconfig.json.