Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix .now() method usage #14

Closed
wants to merge 1 commit into from
Closed

fix .now() method usage #14

wants to merge 1 commit into from

Conversation

janat08
Copy link

@janat08 janat08 commented Mar 24, 2019

the code expects scheduler.now() to exist, I replaced it with timenow() calls.

@briancavalier
Copy link
Member

Hi @janat08. It looks like you're using @most/core. That's great 👍. However, @most/create is compatible with most 1.x. and not with @most/core. I apologize if that wasn't obvious. It's hinted at by the Install section of the README, and @most/create's peerDependency on most 1.x. Here are the type definitions for most 1.x's Scheduler, which has a now method.

I'll add a note to the top of @most/create's README to make the compatibility more clear.

So, if you are using @most.core, once again, that's great! We encourage it's use in all new projects, instead of most. We also encourage trying to avoid imperative options such as @most/create In a @most/core environment. However, there are times where imperative turns out to be the best fit. In such cases, check out @most/adapter, or simply implement the Stream interface. Here's a related, slightly longer read which you may find helpful.

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants