chore(TS): add typescript definitions #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is about the best that typescript can do unfortunately
| // first 2 then 1 | ||
| export function sampleArray<A, B, C>(f: (a: A, b: B[]) => C, sampler: Stream<A>): (s: Stream<B>[]) => Stream<C>; | ||
| // 1 arg at a time | ||
| export function sampleArray<A, B, C>(f: (a: A, b: B[]) => C): (sampler: Stream<A>) => (s: Stream<B>[]) => Stream<C>; |
There was a problem hiding this comment.
This is pretty brutal already, but I think it may need to be expanded even more if we want to really do it right. Like combineArray, I think we need to add polymorphic variants of sampleArray. Unfortunately, having to handle both partial application and polymorphism will cause a combinatoric explosion of type definitions :( Any ideas on other ways to do it?
There was a problem hiding this comment.
I have no idea how to do it in a way that isn't super verbose :/
Brain exploding, hating typescript.
|
I very much remember the parts of TypeScript I don't like... |
|
Terrifying :) Looks right, tho. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is about the best that typescript can do unfortunately